Work around channel overflow for freshly created subscriptions #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new subscription is created, the data is sent directly to the broadcast channel. If this channel overflows because the receiver is not fast enough, the error is not detected by `select!` and the client is left hanging forever. Fix the error detection, so that the client can actually re-subscribe. Since it re-subscribes with existing subscription, the initial data is sent to the mpsc channel that doesn't suffer from the overflow issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new subscription is created, the data is sent directly to the
broadcast channel. If this channel overflows because the receiver is
not fast enough, the error is not detected by
select!and the clientis left hanging forever.
Fix the error detection, so that the client can actually re-subscribe.
Since it re-subscribes with existing subscription, the initial data
is sent to the mpsc channel that doesn't suffer from the overflow
issue.