-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aframe to v1.3.0 #175
Conversation
Can this be merged? We use https://moonrider.xyz/ as a sample for the Wolvic browser and this PR would fix our Chromium based versions. |
You can use https://maxmystere.github.io/moonrider/ while merge is pending |
Sorry for being slow at this. Thanks so much for the patience. |
Thanks so much for tracking the issue down |
@Maxmystere Any ideas for a quick fix of #186 ? |
Sadly I do not own a VR headset at the moment but will get back at it if I ever get my hands on one |
@Maxmystere Thanks so much! If you wanna give it a try you can reproduce #186 without a headset and the WebXR emulator extension. Steps:
When entering VR the controllers activate and the laser pointer on the initial position already hits the keyboard keys causing the following error:
|
Note that this is also broken. It's affected by #186 as well |
I've reverted this PR until we can found a solution for #186 I have created a branch with the state of this merge just in case someone wants to continue: https://github.com/supermedium/moonrider/tree/moonrider1.3.0 It would be great to update to A-Frame 1.5.0 if possible. |
This will fix moonrider on chrome
I took the commit from https://github.com/aframevr/aframe/releases/tag/v1.3.0