Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aframe to v1.3.0 #175

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

Maxmystere
Copy link
Contributor

This will fix moonrider on chrome

I took the commit from https://github.com/aframevr/aframe/releases/tag/v1.3.0

@zakharvoit
Copy link

Can this be merged? We use https://moonrider.xyz/ as a sample for the Wolvic browser and this PR would fix our Chromium based versions.

@Maxmystere
Copy link
Contributor Author

You can use https://maxmystere.github.io/moonrider/ while merge is pending

@dmarcos
Copy link
Member

dmarcos commented Feb 15, 2024

Sorry for being slow at this. Thanks so much for the patience.

@dmarcos dmarcos merged commit ffefb35 into supermedium:master Feb 15, 2024
@dmarcos
Copy link
Member

dmarcos commented Feb 15, 2024

Thanks so much for tracking the issue down

@dmarcos
Copy link
Member

dmarcos commented Feb 20, 2024

@Maxmystere Any ideas for a quick fix of #186 ?

@Maxmystere
Copy link
Contributor Author

Maxmystere commented Feb 20, 2024

Sadly I do not own a VR headset at the moment but will get back at it if I ever get my hands on one
I will at least rebase 1.4.2 and check if it's running to have a base for anyone working on it

@dmarcos
Copy link
Member

dmarcos commented Feb 21, 2024

@Maxmystere Thanks so much! If you wanna give it a try you can reproduce #186 without a headset and the WebXR emulator extension. Steps:

  1. On https://moonrider.xyz/ click begin (with mouse)
  2. Click on search
  3. Enter VR

When entering VR the controllers activate and the laser pointer on the initial position already hits the keyboard keys causing the following error:

  Cannot read properties of undefined (reading '0')
    at i.updateKeyColorPlane (build.js?v=3:1292:1182731)
    at i.tick (build.js?v=3:1292:1181486)
    at HTMLElement.value (a-scene.js:739:34)
    at HTMLElement.value (a-scene.js:789:36)
    at bind.js:12:17
    at onAnimationFrame (three.js:18890:1)
    at Object.onAnimationFrame [as callback] (three.js:9460:1)
    at XRSession$1.<computed>.onDeviceFrame (webxr-polyfill.js:3166:28)

@svillar
Copy link

svillar commented Feb 21, 2024

You can use https://maxmystere.github.io/moonrider/ while merge is pending

Note that this is also broken. It's affected by #186 as well

@dmarcos
Copy link
Member

dmarcos commented Feb 21, 2024

I've reverted this PR until we can found a solution for #186

I have created a branch with the state of this merge just in case someone wants to continue:

https://github.com/supermedium/moonrider/tree/moonrider1.3.0

It would be great to update to A-Frame 1.5.0 if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants