-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PYTHON] Issue 8075 - additionalProperties support #8414
Conversation
…al properties of models with additionalProperties defined.
@@ -620,6 +620,12 @@ class ApiClient(object): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file permissions should stay at 0644
@@ -14,7 +14,7 @@ import six | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file permissions should stay at 0644
Minor revert of the file permissions. Otherwise it LGTM. Thanks! @ivan-gomes |
Reverted the file permissions. Good catch! Thanks. |
after reviewing and test locally (merging upstream master into Thanks a lot @ivan-gomes !!! |
it seems my verification was not ok since build is failing for python, anyway i'll check if it's something i can fix, otherwise i'll file a new issue. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
Fixes #8075.