Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#fix working example/basic/api function #123

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

AntonDzyk
Copy link
Contributor

API functions in example/basic not working.
I'm fix it.
i think it will be useful in the example.

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   84.12%   84.12%           
=======================================
  Files           1        1           
  Lines          63       63           
=======================================
  Hits           53       53           
  Misses          8        8           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbeaf5b...ab468b8. Read the comment docs.

@AntonDzyk
Copy link
Contributor Author

@easonlin404 hello! Eason Lin, please, can you see my PR?

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 4199ce8 into swaggo:master Aug 3, 2020
@easonlin404
Copy link
Member

@AntonDzyk Thanks for your effort on it. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants