Fixes Issue 1829 #1830
Merged
Fixes Issue 1829 #1830
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, you have to fix the failed tests，TestParseDescriptionMarkdown and there may be others. |
|
@sdghchj , have fixed the tests. They have actually caught an issue that would have been introduced. Now I also understand why the code was written like that in the first place. It needs to understand "api" and "api.md". Fixed it, to be able to deal with both inputs. Your review has been dismissed I think, could you re-review or re-approve? |
sdghchj
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fixes the issue described in #1829
Relation issue
#1829
Additional context
The previous logic could select the wrong markdown file if one tag was a substring of another. E.g. "objects" and "my-special-objects".