Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial solutions #7

Open
wants to merge 34 commits into
base: solutions
Choose a base branch
from
Open

Tutorial solutions #7

wants to merge 34 commits into from

Conversation

Crista2019
Copy link
Contributor

Description

Offers a potential implementation for the instructions set out in the exercises branch (#6) and addresses #5

in server/DataSource.java

  • adds two new web agents /unit/secondAgent and /unit/thirdAgent
  • manipulates the data sent to each distinct web agent to make their differences clearer

in server/UnitAgents.java

  • creates simple value lanes of type Long to show single statistics
  • offers an alternative design choice to send multiple stats to one value lane of type Value

in ui/chart.html, ui/gauge.html, ui/pie.html

  • adds a dropdown menu to select the current web agent shown and toggle between all three
  • updates the lane downlink and nodeURI whenever the current agent changes
  • visually emphasize the differences between agents with a color palette change
  • change gauge to draw info from the new stats lane (instead of latest)

Points to be addressed before merge

  • Any style conventions
  • Suggested refactoring/code clarification
  • Places where in-depth comments could be added to explain what is happening on a particular line
  • Missing aspects of swim functionality that would be useful for a user to learn

server/README.md Outdated Show resolved Hide resolved
server/README.md Outdated Show resolved Hide resolved
server/src/main/java/swim/tutorial/UnitAgent.java Outdated Show resolved Hide resolved
server/src/main/java/swim/tutorial/UnitAgent.java Outdated Show resolved Hide resolved
server/src/main/java/swim/tutorial/UnitAgent.java Outdated Show resolved Hide resolved
ui/pie.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants