Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add traces across relayer #205

Closed
wants to merge 19 commits into from
Closed

feat: add traces across relayer #205

wants to merge 19 commits into from

Conversation

P1sar
Copy link
Contributor

@P1sar P1sar commented Jul 27, 2023

Description

Adds Traces across the whole repo.
This is highly depended on changes in CORE repo that needs to be released first

Related Issue Or Context

Closes: n/a

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Go Test coverage is 63.6 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 requested changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found deposit in core is missing deposit data and handler response.

chains/evm/executor/executor.go Outdated Show resolved Hide resolved
chains/substrate/executor/executor.go Outdated Show resolved Hide resolved
chains/substrate/executor/executor.go Outdated Show resolved Hide resolved
chains/substrate/executor/executor.go Show resolved Hide resolved
chains/substrate/listener/event-handlers.go Outdated Show resolved Hide resolved
chains/substrate/listener/listener.go Outdated Show resolved Hide resolved
comm/p2p/libp2p.go Show resolved Hide resolved
example/docker-compose.yml Outdated Show resolved Hide resolved
tss/common/base.go Outdated Show resolved Hide resolved
tss/coordinator.go Show resolved Hide resolved
@mpetrun5
Copy link
Collaborator

mpetrun5 commented Aug 9, 2023

Minor nitpick, but don't really like where ctx is renamed to ctxWithSpan.
If we named the context with everything that is possibly inside it would quickly become unmanageable.
It is fine for it to just be ctx.

@github-actions
Copy link
Contributor

Go Test coverage is 63.6 %\ ✨ ✨ ✨

@P1sar P1sar mentioned this pull request Aug 29, 2023
Open
9 tasks
@P1sar P1sar marked this pull request as ready for review August 29, 2023 14:47
@github-actions
Copy link
Contributor

Go Test coverage is 63.5 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 reviewed Aug 29, 2023
View reviewed changes
chains/evm/executor/executor.go Outdated Show resolved Hide resolved
chains/evm/executor/executor.go Outdated Show resolved Hide resolved
chains/substrate/listener/event-handlers.go Outdated Show resolved Hide resolved
chains/substrate/listener/event-handlers.go Outdated Show resolved Hide resolved
chains/substrate/listener/event-handlers.go Show resolved Hide resolved
chains/substrate/listener/event-handlers.go Outdated Show resolved Hide resolved
chains/substrate/listener/listener.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Go Test coverage is 63.5 %\ ✨ ✨ ✨

@P1sar P1sar requested a review from mpetrun5 September 8, 2023 15:39
@P1sar
Copy link
Contributor Author

P1sar commented Sep 8, 2023

Recent changes require updates from ChainSafe/chainbridge-core#350
Currently go.mod fetch code from this PR, this should be fixed before merging

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Go Test coverage is 64.6 %\ ✨ ✨ ✨

@mpetrun5
Copy link
Collaborator

Closing temporarily.
Will opened later when refactor finishes.

@mpetrun5 mpetrun5 closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5 mpetrun5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@P1sar @mpetrun5 @MakMuftic