Skip to content

Commit

Permalink
Make MimeTypeExtensionGuesser case insensitive
Browse files Browse the repository at this point in the history
  • Loading branch information
vermeirentony committed Apr 16, 2019
1 parent 61094ca commit 9fa2326
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
8 changes: 7 additions & 1 deletion File/MimeType/MimeTypeExtensionGuesser.php
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,12 @@ class MimeTypeExtensionGuesser implements ExtensionGuesserInterface
*/
public function guess($mimeType)
{
return isset($this->defaultExtensions[$mimeType]) ? $this->defaultExtensions[$mimeType] : null;
if (isset($this->defaultExtensions[$mimeType])) {
return $this->defaultExtensions[$mimeType];
}

$lcMimeType = strtolower($mimeType);

return isset($this->defaultExtensions[$lcMimeType]) ? $this->defaultExtensions[$lcMimeType] : null;
}
}
Binary file added Tests/File/Fixtures/case-sensitive-mime-type.xlsm
Binary file not shown.
13 changes: 13 additions & 0 deletions Tests/File/UploadedFileTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,19 @@ public function testGuessClientExtensionWithIncorrectMimeType()
$this->assertEquals('jpeg', $file->guessClientExtension());
}

public function testCaseSensitiveMimeType()
{
$file = new UploadedFile(
__DIR__.'/Fixtures/case-sensitive-mime-type.xlsm',
'test.xlsm',
'application/vnd.ms-excel.sheet.macroEnabled.12',
filesize(__DIR__.'/Fixtures/case-sensitive-mime-type.xlsm'),
null
);

$this->assertEquals('xlsm', $file->guessClientExtension());
}

public function testErrorIsOkByDefault()
{
$file = new UploadedFile(
Expand Down

0 comments on commit 9fa2326

Please sign in to comment.