Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner with non-default options, e.g. "privileged" profile, not working in Sympa 6.2.67b.3 #1329

Closed
dpc22 opened this issue Jan 19, 2022 · 15 comments · Fixed by #1379, #1387 or #1462
Closed
Assignees
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@dpc22
Copy link
Contributor

dpc22 commented Jan 19, 2022

Version

6.2.67b.3

Installation method

My own rpm.

Expected behavior

If I add a new owner to a list with "privileged owner" set, they should be added as a privileged owner.

Actual behavior

The new owner is added as a normal owner, which I then have to go in and change via the edit owner dialogue.

@dpc22 dpc22 changed the title Add privileged owner not working in Sympa 6.2.67b.3 Add privileged owner not working in Sympa 6.2.67b.3 Jan 19, 2022
@dpc22
Copy link
Contributor Author

dpc22 commented Jan 19, 2022

The two checkboxes on the "Add moderators" dialogue seem to have the same problem:

no notifications
concealed from list menu

@dpc22
Copy link
Contributor Author

dpc22 commented Jan 19, 2022

I infer that this is in some way related to:

default_owner_options owner read
default_editor_options owner read

which are new in 6.2.67

@ikedas
Copy link
Member

ikedas commented Jan 20, 2022

Owner addition specifying their attributes has not yet implemented. It will be postponed to the next of next stable.

@dpc22
Copy link
Contributor Author

dpc22 commented Jan 20, 2022

Okay, I think that this will confuse my users unless the various checkboxes (which currently do not function) are removed.

I can always wait until 6.2.70

@iulistadmin
Copy link

Another vote to fix this bug. We have had this issue called to our attention. We are running 6.2.68 on CentOS 7.

@ikedas ikedas added bug and removed enhancement labels Mar 1, 2022
@ikedas ikedas self-assigned this Mar 1, 2022
@ikedas ikedas changed the title Add privileged owner not working in Sympa 6.2.67b.3 Add owner with non-default options, e.g. "privileged" profile, not working in Sympa 6.2.67b.3 Mar 10, 2022
@ikedas
Copy link
Member

ikedas commented Apr 16, 2022

@dpc22, @iulistadmin (#1329) and @renesepp (#1361), could you please apply this patch to check if the problem will be solved? Thank you.

@dpc22
Copy link
Contributor Author

dpc22 commented Apr 16, 2022

Will do, although it will probably be a couple of weeks now because of Easter and other leave.

Thanks for fixing this. It was stopping me from upgrading to 6.2.68.

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Apr 16, 2022
@iulistadmin
Copy link

Thanks @ikedas! We don't seem to have wwsympa.fcgi.in. In our installation, there is /usr/libexec/sympa/wwsympa.fcgi. It looks like this is the file to modify, but when I applied the patch, it broke the web UI.

@ikedas
Copy link
Member

ikedas commented Apr 19, 2022

@iulistadmin , is the permission (file mode) of wwsympa.fcgi correct? If patch is applied, sometimes execution bits are cleared. The mode should be 755 (rwxr-xr-x).

@iulistadmin
Copy link

@ikedas, that was the problem. I should have been more careful and checked the permissions on that file. Having the correct permissions set, the patches applied, it is now setting the privileged owners correctly. So, this has resolved the issue for us. Thank you!

@ikedas
Copy link
Member

ikedas commented Apr 26, 2022

@iulistadmin , thank you for confirming! The patch will be merged soon.
@dpc22, this issue will be closed soon, but if you noticed anything, please feel free to comment on this page.

ikedas added a commit that referenced this issue Apr 26, 2022
WWSympa: Adding owner/moderator with non-default options does not work (#1329)
@dpc22
Copy link
Contributor Author

dpc22 commented Apr 26, 2022

A bit late, but I can confirm that this seems to have fixed the problem for me. Thanks.

@dpc22
Copy link
Contributor Author

dpc22 commented Apr 26, 2022

Oh, one small thing. "default_owner_options" and "default_editor_options" are grouped under "Sending/receiving setup":

    default_owner_options => {
        context         => [qw(list domain site)],
        order           => 20.06_02,
        group           => 'sending',
    [...]
    default_editor_options => {
        context         => [qw(list domain site)],
        order           => 20.06_03,
        group           => 'sending',

I would have expected these two options to appear under "Privileges" or maybe "Miscellaneous". It doesn't really seem to be a "sending" option.

ikedas added a commit to ikedas/sympa that referenced this issue Apr 26, 2022
@ikedas
Copy link
Member

ikedas commented Apr 26, 2022

Makes sense. It'll be fixed.

@ilf
Copy link

ilf commented Oct 26, 2022

Thanks everyone. Can we get a new release with this fix included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
4 participants