Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default_ttl parameter #145

Closed
aepli opened this issue Dec 20, 2017 · 2 comments
Closed

Restore default_ttl parameter #145

aepli opened this issue Dec 20, 2017 · 2 comments
Milestone

Comments

@aepli
Copy link
Contributor

aepli commented Dec 20, 2017

Hello,

The default_ttl parameter in the /etc/sympa/sympa.conf configuration file is not used as the default value for the Inclusion timeout (ttl) parameter of a list.

The default value of the ttl parameter remains at 3600 seconds.

Comparing between 6.1.17 and 6.2.22, I noticed that the definition of the ttl parameter has changed.

With the 6.1.17 in the List.pm library, we had:

List.pm

'ttl' => {'format' => '\d+',
          'length' => 6,
          'gettext_unit' => 'seconds',
          'default' => {'conf' => 'default_ttl'},
          'gettext_id' => "Inclusions timeout",
          'group' => 'data_source'
          },

With the 6.2.22 in the ListDef.pm library, we have:

ListDef.pm

'ttl' => {
    order          => 60.12,
    'group'        => 'data_source',
    'gettext_id'   => "Inclusions timeout",
    'gettext_comment' =>
        'Sympa caches user data extracted using the include parameter. Their TTL (time-to-live) within Sympa can be controlled using this parameter. The default value is 3600',
    'gettext_unit' => 'seconds',
    'format'       => '\d+',
    'default'      => 3600,
    'length'       => 6
},

As you can see on the 6.2.22 there isn't anymore the reference "default_ttl" in the key "default".

Regards.

Debian 9.2
Perl 5.24.1
exim4 4.89
mariadb 15.1
apache2 2.4.25
sympa 6.2.22

@ikedas
Copy link
Member

ikedas commented Dec 22, 2017

Hi @aepli,

I found these default_* parameters have been unused in trunk before 6.2alpha. There seem no reason. if it is useful, I feel default_ttl may be restored.

@ikedas
Copy link
Member

ikedas commented Jan 6, 2018

There seems not significant problem restoring this parameter, and I’ll restore it.

ikedas added a commit that referenced this issue Jan 6, 2018
Restore default_ttl #145 by Ikedas
@ikedas ikedas closed this as completed Jan 6, 2018
@ikedas ikedas added this to the 6.2.26 milestone Jan 7, 2018
@ikedas ikedas changed the title The default_ttl parameter is no longer used in Sympa 6.2.22 Restore default_ttl parameter Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants