Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template error parsing not detected #1474

Closed
simonelbaz opened this issue Sep 5, 2022 · 3 comments · Fixed by #1477
Closed

Template error parsing not detected #1474

simonelbaz opened this issue Sep 5, 2022 · 3 comments · Fixed by #1477
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@simonelbaz
Copy link

Hi,

I am trying to create automatic list using config.tt2 template as suggested in documentation.

An exception is throwed but no error is logged.

After digging into the code (

if (not $tt_result and $abort_on_error) {
), the abort_on_error variable is never set. So even if the template throws an error, it will not be logged.

I didn't find the place where to set abort_on_error to true in order to be able to log template errors.

Thanks for you help

@ikedas
Copy link
Member

ikedas commented Sep 10, 2022

Hi @simonelbaz ,

Could you please apply this patch and check if the error will be logged?

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Sep 10, 2022
@simonelbaz
Copy link
Author

Hi @ikedas,

Bug fixed after applying your patch:

sympa-web-21_1  | Sep 12 13:05:28 sympa-web-21 sympa_automatic[210]: err main::#164 > Sympa::Spindle::spin#83 > Sympa::Spindle::ProcessAutomatic::_twist#262 > Sympa::S
pindle::spin#95 > Sympa::Request::Handler::create_automatic_list::_twist#99 Can't parse /etc/sympa/*****/families/****/config.tt2: auto
family error - SYNTAX ERROR: *****

Thanks a lot

@ikedas ikedas added this to the 6.2.72 milestone Sep 24, 2022
ikedas added a commit that referenced this issue Nov 15, 2022
Template error parsing not detected (#1474)
@ikedas
Copy link
Member

ikedas commented Nov 15, 2022

Merged. @simonelbaz , thank you for reporting bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants