Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attributes synchronization fail #1535

Closed
dverdin opened this issue Nov 28, 2022 · 2 comments · Fixed by #1536
Closed

Custom attributes synchronization fail #1535

dverdin opened this issue Nov 28, 2022 · 2 comments · Fixed by #1536
Labels
Milestone

Comments

@dverdin
Copy link
Contributor

dverdin commented Nov 28, 2022

Version

6.2.70

Installation method

From the sources

Expected behavior

When defining a parameter include_sql_ca, data are retrieved from an SQL datasource and stored in each subscribers corresponding custom attributes.

Actual behavior

The custom attributes never synchronize.

Steps to reproduce

  • Create a custom attribute called 'a',
  • Create an include_sql_query retrieving, during the query, a field also called 'a',
  • go to the review page and hit the "Synchronize list members" button,
  • Though a a column for the custom attribute appears, the custom attribute is not populated for the list members.

Additional information

PR #1534 fixes this bug.

@dverdin
Copy link
Contributor Author

dverdin commented Nov 30, 2022

You PR goes further, and does not break anything, so I 'm OK with it.

@ikedas ikedas changed the title SQL custom attributes synchronization fail Custom attributes synchronization fail Nov 30, 2022
@dverdin
Copy link
Contributor Author

dverdin commented Nov 30, 2022

I cherry-picked #1536 and put it in production.
Added users have their custom attributes correctly parsed and these custom attributes are used without any template change by Sympa.
So you got the code simplified without any impact on listmasters, which seems good.

Thank you.

@ikedas ikedas added this to the 6.2.72 milestone Dec 5, 2022
ikedas added a commit that referenced this issue Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants