Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify scenario names #216

Closed
qosobrin opened this issue Mar 1, 2018 · 3 comments
Closed

Unify scenario names #216

qosobrin opened this issue Mar 1, 2018 · 3 comments
Labels
Milestone

Comments

@qosobrin
Copy link
Contributor

qosobrin commented Mar 1, 2018

I understand that this is just a matter of aesthetics here and my request is not very important, but there are some scenarios named:

access_web_archive.closed
access_web_archive.intranet
access_web_archive.listmaster
access_web_archive.owner
access_web_archive.private
access_web_archive.public

while others are named using a different pattern:

archive_mail_access.closed
archive_mail_access.default
archive_mail_access.owner
archive_mail_access.private
archive_mail_access.public

Only one pattern would be desirable, either archive_mail_access.* and archive_web_access.* , or access_web_archive.* and access_mail_archive.*

Thank you very much.
Regards.

@ikedas
Copy link
Member

ikedas commented Mar 1, 2018

@qosobrin, I agree to consistent naming. Please go on.

@ikedas ikedas added the bug label Mar 1, 2018
@ikedas ikedas added this to the 6.2.26 milestone Mar 10, 2018
ikedas added a commit that referenced this issue Mar 10, 2018
Issue #216: Unify scenario names #217 by qosobrin
@ikedas
Copy link
Member

ikedas commented Mar 10, 2018

@qosobrin, your PR was merged. Thanks for good change!

@ikedas ikedas closed this as completed Mar 10, 2018
@qosobrin
Copy link
Contributor Author

Sorry for the delay. I was out for a while. Thank you for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants