Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKIM per-list options not saved #412

Closed
jrlevine opened this issue Sep 11, 2018 · 10 comments
Closed

DKIM per-list options not saved #412

jrlevine opened this issue Sep 11, 2018 · 10 comments
Labels
Milestone

Comments

@jrlevine
Copy link

jrlevine commented Sep 11, 2018

Version

6.2.34

Installation method

source package

Expected behavior

Update DKIM parameters like selector or private key file, should be saved in list config file

Actual behavior

not saved in list config file

Additional information

dkim_feature and dkim_signature_apply_on are saved, but stuff in the dkim_parameters section are not

@jrlevine
Copy link
Author

Note: if you hand-edit the parameters into the config file, it'll read it properly, but if you save it
from the CGI, nothing gets saved, not even the old values.

@ikedas
Copy link
Member

ikedas commented Sep 12, 2018

Hi @jrlevine,

Could you please apply this patch and check if the problem will be solved? Thanks!

@ikedas ikedas added the bug label Sep 12, 2018
@ikedas ikedas added this to the 6.2.36 milestone Sep 12, 2018
@jrlevine
Copy link
Author

I applied the patch and it didn't fix the problem. As an experiment I commented out the obsolete header_list sub-parameter in ListDef.pm and it still didn't save the paragraph.

@ikedas
Copy link
Member

ikedas commented Sep 12, 2018

Just in case, did you force reloading web service?

@jrlevine
Copy link
Author

jrlevine commented Sep 12, 2018 via email

@ikedas
Copy link
Member

ikedas commented Sep 13, 2018

It's in a test setup with plain CGI, the web service starts up for every
www request.

CGI mode was deprecated on 6.2.24 (see #69). I think you may have to restart web services, wwsympa.fcgi process and HTTPd.

@jrlevine
Copy link
Author

jrlevine commented Sep 13, 2018 via email

@ikedas
Copy link
Member

ikedas commented Sep 13, 2018

I don't know whether wwsympa will work sanely as plain CGI or not. Anyways, on my environments with FastCGI, either:

  • Apache 2.2 + mod_fcgid + wwsympa-wrapper.fcgi + wwsympa.fcgi 6.2.35b.1
  • nginx + spawn_fcgi + wwsympa.fcgi 6.2.35b.1

the problem was reproduced, and was solved by applying the patch.

@jrlevine
Copy link
Author

I'm now running Apache 2.4 + mod_proxy + mod_proxy_fcgi + spawn_fcgi + wwsympa-wrapper.fcgi + 6.2.35b.1 and it doesn't work. Who knows, will try again after I finish the ARC patches.

ikedas added a commit that referenced this issue Sep 13, 2018
edit_list: Paragraph including obsoleted sub-parameter is ignored #412
@ikedas
Copy link
Member

ikedas commented Sep 13, 2018

Thanks for confirming. I'll merge pr at the present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants