Inconsistent location of messge footer/header files #507
Comments
ikedas
added a commit
to ikedas/sympa
that referenced
this issue
Jan 4, 2019
Fixes:
- Message footer/header files of domain/site default are put in `mail_tt2` subdirectories while those of list config are not.
Fixed by put all of them in consistent location without intermediate directories (See also Notes below).
- Entries for header/footer files in `edit_list.conf` were ignored.
Changes:
- File names themselves of header/footer were changed:
`message_header`, `message_header.mime` etc.
This is due to concideration about conflict between files and directories with domain names (See also Notes below).
- Header/footer files with `.mime` extension:
Previously, files with this extension were always preferred, then files without extension were used. This behavior has not been documented.
Now files with extension will be searched only in case `footer_type` is `mime`. Files without extension will be searched in both cases.
Notes:
- Files with older names/paths in list/domain/site config directories will be copied to new location during upgrading process.
- Template files with old names in families (`message.header.tt2` etc.) will be used as before and will be copied to new location during instantiation. If files with new names (`message_header.tt2` etc.) will be preferred, if they will be added.
Known bug:
- There are no web UI to edit global footer (`message_global_footer`).
ikedas
added a commit
that referenced
this issue
Jan 30, 2019
Inconsistent location of messge footer/header files #507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
6.2.38 and earlier.
Installation method
Any.
Actual and expected behaviors
Currently, message footer/header files of domain/site default are put in
mail_tt2subdirectory while those of list config are not. I suggest consistent location to put them outside ofmail_tt2subdirectory. For example with message header:$EXPLDIR/list path/message.header$EXPLDIR/list path/message_header$SYSCONFDIR/domain/message_header$SYSCONFDIR/mail_tt2/message.header$SYSCONFDIR/message_headerNote: There is another consideration in the proposal above: Since $SYSCONFDIR may have domain subdirectories, name of config files in this directory should not consist only of alphanumeric letters and dots (
message.header). That's why file names including_are suggested.Additional information
Global message footer (introduced by #301) also applies.
2018-12-14 edit: Corrected the table.
The text was updated successfully, but these errors were encountered: