Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some modules for spool-like objects #608

Closed
ikedas opened this issue Apr 27, 2019 · 0 comments
Closed

Rename some modules for spool-like objects #608

ikedas opened this issue Apr 27, 2019 · 0 comments
Labels
design
Milestone
6.2.46

Comments

@ikedas
Copy link
Member

ikedas commented Apr 27, 2019 •
edited
Loading

Though these are not really subclasses of Sympa::Spool, but treated as spools by some Sympa::Spindle subclasses. So I propose renaming them to be look like spools.

Current name Proposed name Description
Sympa::Alarm Sympa::Spool::Listmaster On-memory spool for notifications to listmaster
Sympa::Bulk Sympa::Spool::Outgoing Outgoing spool
Sympa::Topic Sympa::Spool::Topic Topic cache
Sympa::Spindle::ToAlarm Sympa::Spindle::ToListmaster Spindle to store into listmaster spool

EDIT: Added Sympa::Spindle::ToAlarm.
@ikedas ikedas added the design label Apr 27, 2019
ikedas added a commit to ikedas/sympa that referenced this issue Aug 2, 2019
@ikedas
Rename some modules for spool-like objects sympa-community#608
746175a
@ikedas ikedas mentioned this issue Aug 2, 2019
Merged
@ikedas ikedas added this to the 6.2.46 milestone Aug 2, 2019
ikedas added a commit that referenced this issue Aug 9, 2019
@ikedas
Merge pull request #717 from ikedas/issue-608
9d5e1f8 
Rename some modules for spool-like objects #608
@ikedas ikedas closed this as completed Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
6.2.46
Development

No branches or pull requests
1 participant
@ikedas