Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No date header in messages posted directly from the sympa web site #791

Closed
scheff opened this issue Nov 8, 2019 · 6 comments · Fixed by #793
Closed

No date header in messages posted directly from the sympa web site #791

scheff opened this issue Nov 8, 2019 · 6 comments · Fixed by #793
Labels
Milestone

Comments

@scheff
Copy link

scheff commented Nov 8, 2019

Version

Sympa 6.2.44
Debian GNU/Linux 9.11 (stretch)

Installation method

source package

Expected behavior

Messages shown in the archive of an list
URL: .../sympa/arc/LISTNAME/YYYY_MM/
should be included in the output when queriing the latest messages of a list
URL: .../sympa/latest_arc/LISTNAME?count=10

Actual behavior

Messages send after upgrading to Sympa 6.2.44 are not included in the output of latest_arc.

Additional information

After editing a message and inserting a the header manually, e.g.

Date: Fri, 25 Oct 2019 11:11:11 +0000

and rebuilding the archive ther message is shown in the output of latest_arc.

@ikedas
Copy link
Member

ikedas commented Nov 8, 2019

Hi @scheff,

Could you please apply this patch and check if Date field will be inserted properly?

And for my information: What are the name and version of MTA software you are using with Sympa?

@ikedas ikedas added the bug label Nov 8, 2019
@ikedas ikedas added this to the 6.2.50 milestone Nov 8, 2019
@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Nov 8, 2019
@racke
Copy link
Contributor

racke commented Nov 8, 2019

@ikedas I actually thought about asking the MTA question. But independent of that we should add the date, otherwise we get an "unknown" date in the moderation overview. Thanks for your patch!

@ikedas
Copy link
Member

ikedas commented Nov 8, 2019

@racke you are right. My Postfix has been overprotectively adding missing Date field and I have never realized it was missing!

@racke
Copy link
Contributor

racke commented Nov 8, 2019

Emails originating from the "compose email" are processed before submitted to a MTA, that's why we got the problem. I suppose that all established MTAs are adding standard fields like Message-ID and Date if they are missing.

@scheff
Copy link
Author

scheff commented Nov 11, 2019 via email

ikedas added a commit that referenced this issue Nov 11, 2019
WWSympa: compose_mail: "Date:" field was omitted. Add it. (#791)
@ikedas ikedas removed the ready A PR is waiting to be merged. Close to be solved label Nov 11, 2019
@ikedas
Copy link
Member

ikedas commented Nov 11, 2019

@scheff, thanks so much for confirming fix! The fix will be included in the next stable release, maybe 6.2.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants