Fix and speed up make_alias_file Sympa command #1046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racke
changed the title
ikedas
reviewed
Nov 30, 2020
| else { | ||
| system($alias_manager, 'add', $list->{'name'}, $list->{'domain'}, | ||
| $sympa_aliases); | ||
| } |
There was a problem hiding this comment.
I realized that --make_alias_file option should be effective only if the value of alias_manager is either "Template" or $SBINDIR/alias_manager.pl, and in both cases Sympa::Aliases::Template may be used.
In the other cases (none, CheckSMTP or arbitrary program) alias files won't be generated.
There was a problem hiding this comment.
OK, that makes sense to me. Should I adjust the PR accordingly?
ikedas
added a commit
that referenced
this pull request
Feb 2, 2021
Fix and speed up make_alias_file Sympa command (#1046)
|
See #1084. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it breaks when alias_manager is set to
Templatewhich is the recommended setting as far as I know. It is also much faster than calling a script for each list.