Suppress saving stats file, and solve problem about on-memory cache #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts file occur. This issue was reported by a listmaster. Write accesses are caused to save total count of subscribers. This information does essentially not have to be stored into disk: It can be got by database query. This commit deprecated "total" field in stats file so that write accesses are suppressed.
Fixed by publishing the last sync by .last_sync.member file in list directory so that the last time of update may be shared among processes.
Fixed by publishing the last change and sync by .last_chage.member and .last_sync.member files in list directory so that the last time of update may be shared among processes. This change possiblly can solve issue sympa-community#7.
… instance were deprecated. Instead, Sympa::List::update_stats() would be used. Unneeded write accesses were suppressed, and thanks to file locking, following bug was fixed: - [bug] X-sequqnce header field in distributed messages will occasionally not be increased.
…) in Sympa::List are redundant.
…st::init_list_cache().
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscribers are imported, frequent write accesses to listdir
/statsfile occur. This issue was reported by a listmaster. According to investigation, content of this file must not being cached on memory, but rather be shared among processes.Changes:
.last_change.memberand.last_change.adminfiles in list directory..last_sync.memberand.last_sync.adminfiles in list directory.statsfile (total, last_sync, last_sync_admin) are removed.Fixed bugs:
As a side work, barely effective cache by
%list_cacheandinit_list_cache()were removed.