Improve MHonArc resource file #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andom string) in mhonarc-ressources.tt2
|
Looks good to me. |
ldidry
approved these changes
Jan 25, 2021
|
@salaun-urennes1 , if you remember, could you please tell us what was the actual problem -- how "archives were not properly TT2 parsed" --- that needed the change on sympa-community/historic-sympa@c1e50fa ? |
|
Hi Soji, Sorry, but I did this commit 16 years ago. |
Well, it's true. :-) |
|
This was once merged to #1094. Close. |
ikedas
added a commit
to ikedas/sympa
that referenced
this pull request
Feb 9, 2021
…e file) under sympa-community#1091 - Update POTFILES for changing name of a file - Update xgettext.pl for the new tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposal of extensive change for #1091.
<%...%>instead of variable tags in MHonArc resource fileUse
<%...%>instead of variable tags in MHonArc resource fileAccording to history, at the first time MHonArc resource file adopted TT2, the tags
<-%...%->were used [1]. But it was changed to(-%...%-)by the reason that "archives were not properly TT2 parsed" [2]. In fact, if current code is modified to use that tags, extracted archive page may contain the lines such as:<!--X-Derived: #60#45% path_cgi %#45>/viewmod/listname/.../pngVTalOgmofN.png -->This is not well-formed if it was parsed as XHTML or HTML 4. However it is legitimate comment for HTML5.
Afterward,
(xxx%...%xxx)(xxxis variable text) were introduced to make tags unpredictable so that (maybe) code injection would be prevented [3]. However, strictly logically speaking, this is not a perfect measure. On the other hand, the texts including<and>cannot be injected thanks to MHonArc that escapes input.Therefore, now we would be better to use secure tags
<%...%>instead of variable tags.Rename resource file
Currently the file name is
mhonarc-ressources.tt2.The French spelling "ressources" would be better to be avoided.
Furthermore, names consisting of alphanumeric letters and dot(s) only (and optionally hyphen(s)) should be avoided as they may conflict with the domain name: SYSCONFDIR can contain the directories named by domain.
Suggested name is
mhonarc_rc.tt2.Incidental measure
Existing
mhonarc-ressources.tt2will be converted tomhonarc_rc.tt2during upgrading process.[1] sympa-community/historic-sympa@e1d3d41, src/etc/mhonarc-ressources (2004-05-06)
[2] sympa-community/historic-sympa@c1e50fa (2004-06-24)
[3] sympa-community/historic-sympa@eb39494 (2004-12-02) and sympa-community/historic-sympa@96197b2 (2004-12-14)