Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete="off" to all forms unless explicitly enabled. #1114

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Feb 5, 2021

Known bug

However, this cannot prevent heuristics by Google Chrome.
@ikedas ikedas added this to the 6.2.62 milestone Feb 5, 2021
@racke
Copy link
Contributor

racke commented Feb 6, 2021

Can you please explain why autocomplete needs to be off on all forms?

@ikedas
Copy link
Member Author

ikedas commented Feb 7, 2021

Can you please explain why autocomplete needs to be off on all forms?

Not all.

W3C/WAI WCAG21 recommends that "each input field collecting information about the user" implements technology to support inputs, such as auto-completion. That's why this PR enables auto-completion on login and renewpasswd forms.

However, auto-completion features currently common browsers implement are not suitable for the other forms: Those features support input of information about the user of the browser itself, while those forms (e.g. subscribers management) may be used to input the information about the other users. Therefore, enabling such features can be a securirty risk.

@ikedas ikedas merged commit f4c3d9f into sympa-community:sympa-6.2 Feb 16, 2021
@ikedas ikedas deleted the issue-1033_trial1 branch February 16, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants