Make it clear that wwsympa_url needs to include the protocol #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents confusion seen at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929157#15 sympa-community#876 (comment) Even better to have a format that checks whether it is a valid URL. E.g. by feeding it to the URI module and verify that all vital parts are present.
I have read this bugreport and at the time felt good idea to omit schema in URL (it's a legitimate notation of relative URI reference: See RFC3986, 4.2). But now I know it's impossible. This omission is useful in HTML source, because protocol of URLs may be taken from base URL the browser is accessing. However, it cannot apply to the parameter(s) of Sympa, because the server has to give the protocol used by itself.
I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents confusion seen at:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929157#15
#876 (comment)
Even better to have a format that checks whether it is a valid URL.
E.g. by feeding it to the URI module and verify that all vital parts
are present.