Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty paragraph in list config should not be warned. #1150

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Apr 15, 2021

@ikedas ikedas added the bug label Apr 15, 2021
@ikedas ikedas added this to the 6.2.64 milestone Apr 15, 2021
@ikedas
Copy link
Member Author

ikedas commented Apr 15, 2021

Hi @bmarchal54 , could you check this ?

@bmarchal54
Copy link
Contributor

Hello,
I'm sorry, but I'm not very expecting in app development.
What do I have to test?
Kind regards

@ikedas
Copy link
Member Author

ikedas commented Apr 15, 2021

I'm sorry, but I'm not very expecting in app development.
What do I have to test?

If you are still experiencing the problem about logging, if possible, could you please apply the change by this PR and see if the problem will be solved?

Note that I don't recommend to apply the change on production server.

@bmarchal54
Copy link
Contributor

I don't know what change you are asking me to apply.
Frankly, git is a mystery to me.
I am on 6.2.60 on my test server.

@ikedas
Copy link
Member Author

ikedas commented Apr 15, 2021

I don't know what change you are asking me to apply.

Sorry for poor instruction. Could you please apply this patch, (restart Sympa services as necessity) and check if the problem will be solved?

@bmarchal54
Copy link
Contributor

It's a bit like me who is not very efficient. Do not apologize.
I no longer have the error / warning message in the logs.

The problem which is at the origin of this is still the rewriting of the configuration file of the list which forgets (or forgot in previous versions of SYMPA) to carry over the lines of the paragraph.

cordially

@ikedas
Copy link
Member Author

ikedas commented Apr 16, 2021

I no longer have the error / warning message in the logs.

Thank you for confirming! This fix will be included in the next of the next release (maybe 6.2.64).

The problem which is at the origin of this is still the rewriting of the configuration file of the list which forgets (or forgot in previous versions of SYMPA) to carry over the lines of the paragraph.

I think so too. I guess config file has been modified during upgrading process, however I haven't find out where it has been done.

@bmarchal54
Copy link
Contributor

bmarchal54 commented Apr 17, 2021 via email

@ikedas ikedas merged commit 71d1c9e into sympa-community:sympa-6.2 Apr 27, 2021
@ikedas ikedas deleted the empty_paragraph branch April 27, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants