Refactoring alias manager: Obsolete alias_manager.pl #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anagement. Sympa::Admin was deprecated.
…_manager.pl - If value of alias_manager parameter has full path of alias_manager.pl as value, Sympa::Aliases::Template module will be used instead of invoking alias_manager.pl. - alias_manager.pl would be removed in the future.
… skipped. [bug] return_path address won't be checked if list_check_suffixes doesn't include it.
… value of ``host`` parameter of the list, not mail domain: If ``host`` parameter was not the same as domain name, external program could fail. Fixed by feeding mail domain instead of ``host`` value. And added [% list.host %] template variable to use ``host`` value in template. Note that ``host`` parameter may be deprecated in the future (See issue sympa-community#43).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new class:
Base class for aliases management.
Added these subclasses:
Check addresses using SMTP
Updating aliases by external program
Aliases file based on template
alias_manager.plwas obsoleted: If value ofalias_managerparameter is full path to this utility, Sympa::Aliases::Template will be used instead. Thoughalias_manager.plis left for compatibility, it would be better to be removed in the future.Sympa::Admin was deprecated (removed).
Fixed bugs:
list_check_suffixesis not set, list address verification is skipped.list_check_suffixesdoesn't include it.hostparameter of the list, not mail domain: Ifhostparameter was not the same as domain name, external program could fail.Fixed by feeding mail domain instead of
hostvalue. And added [% list.host %] template variable to usehostvalue in template.Note that
hostparameter may be deprecated in the future (See issue List parameter "host" should be abolished #43).