Characters in pages are garbled (get "mojibake") with Perl 5.22.0 or later #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users in non-Latin-1 languages (language other than "en", "de", "fr", ...) will notice this bug. Background: Starting with Perl 5.22.0, POSIX::strftime() returns Unicode (utf8 flag set) string under UTF-8 locale. - https://metacpan.org/pod/release/SHAY/perl-5.26.1/pod/perl5220delta.pod#Better-heuristics-on-older-platforms-for-determining-locale-UTF-8ness - https://perl5.git.perl.org/perl.git/commit/9717af6d049902fc887c412facb2d15e785ef1a4 Sympa::Language::gettext_strftime() uses it to format localized date/time, and utf8-flagged texts were mixed in the output. Fixed by dropping utf8 flag from the result of POSIX::strftime().
ikedas
changed the title
|
In most cases it should not be necessary to mess with the UTF-8 flags, so maybe the real problem is elsewhere? |
|
Well, this type of problem messes non-Latin-1 people. Sympa uses binary UTF-8 (utf8 flag off) as internal text encoding, not Unicode (utf8 flag on). Today several modules return Unicode strings as results. Mixture of binary UTF-8 and Unicode strings will be "upgraded" to Latin-1 encoded by Unicode (and print() will issue "wide characters" warnings). So with Latin-1 people, problem will often not be actualized. However with non-Latin-1 people, things are serious: Most or all of non-ASCII letters will be broken. |
ikedas
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was reported by a japanese listmaster. Users in non-Latin-1 languages (language other than "en", "de", "fr", ...) will notice this bug. Latin-1 users rarely realize it but warnings are spit out to error log:
Background: Starting with Perl 5.22.0, POSIX::strftime() returns Unicode (utf8 flag set) string under UTF-8 locale.
Sympa::Language::gettext_strftime() uses it to format localized date/time, and utf8-flagged texts were mixed in the output.
Fixed by dropping utf8 flag from the result of POSIX::strftime().
4 Dec Update: Added warning message.