Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 — Missing some id on input tags #1358

Merged
merged 1 commit into from
Mar 17, 2022
Merged

🐛 — Missing some id on input tags #1358

merged 1 commit into from
Mar 17, 2022

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Mar 8, 2022

Therefore, clicking on the label did not change the state of the checkbox.

@ldidry ldidry changed the title 🐛 — Missing input id in checkbox input 🐛 — Missing id in checkbox input Mar 8, 2022
@ikedas
Copy link
Member

ikedas commented Mar 9, 2022

There are more elements missing id properties, as far as I know:

  • arcsearch_form.tt2:
    directories
  • d_properties.tt2:
    new_name
  • review.tt2:
    param.[% pS.name %].[% oI %].[kS.name ] (typo in template syntax)
  • scenario_test.tt2:
    remote_addr
    remote_host

@ikedas ikedas added the bug label Mar 9, 2022
@ldidry ldidry changed the title 🐛 — Missing id in checkbox input 🐛 — Missing some id on input tags Mar 9, 2022
@ldidry
Copy link
Contributor Author

ldidry commented Mar 9, 2022

Thank you for the other missing ids. I added them.

@ikedas ikedas merged commit 7793e7c into sympa-community:sympa-6.2 Mar 17, 2022
@ikedas ikedas added this to the 6.2.70 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.70
Development

Successfully merging this pull request may close these issues.
2 participants
@ldidry @ikedas