Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading CSV driver crashes #1435

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Loading CSV driver crashes #1435

merged 1 commit into from
Nov 15, 2022

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Jul 1, 2022 •
edited
Loading

Loading CSV driver crashes, because customizing $SIG{__DIE__} by Sympa::Crash breaks processing in File::stat .

This may fix #1434.

@ikedas ikedas marked this pull request as ready for review July 1, 2022 09:34
@salaun-urennes1
Copy link
Collaborator

I tried the PR:

  • problem to add a CSV data source with no db_name, db_host and db_user still remains;
  • once I added the include_sql_query with dummy db_name, db_host and db_user, sync_include() works fine without the previous exception.

@ikedas ikedas merged commit 7f8f78b into sympa-community:sympa-6.2 Nov 15, 2022
@ikedas ikedas deleted the issue-1434_part-2 branch November 15, 2022 09:05
@ikedas ikedas added the bug label Nov 22, 2022
@sympa-community sympa-community deleted a comment May 5, 2024
@sympa-community sympa-community locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include_sql_query broken for CSV database driver
2 participants
@ikedas @salaun-urennes1