sympa.pl: Improving --dump_users and adding --restore_users, and related fixes #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They dump or restore list users (members, owners or editors) in database from/to file. [change] File for members was changed to `<list dir>/member.dump` which will replace: - `subscribers` (used by Sympa prior to 5.4a.1) - `subscribers.db.dump` (generated by dump command) - `subscribers.closed.dump` (backup for closed list) [change] Additional files to dump owner or editor: `<list dir>/owner.dump`, `<list dir>/editor.dump`. They will be used as initial (permanent) owners/editors, or as backup for closed list [*change] owner and editor parameters in list config file are no longer sync with actual owners/editors. They are used only at the time of installation of list.
…gistered as permanent (not included) members. Also, subscription suspension option are cleared and so on. Fxied by dump and restore all information of subscribers in database.
- `--dump` dumps list members/owners/editors to file under list directory. - `--suck` restores list members/owners/editor from this file.
|
Commandline option --suck sounds weird to me, what about --import-from-dump or --restore? |
|
The word "restore" has already been used: "Restore (closed) list", "Restore (suspended) subscription". Also Sympa has already had a function named "import", and I feel this function is a bit different from function to "import". How about "store"? |
…), respectively. Options for sympa.pl are also renamed to --dump_users and --restore_users.
ikedas
changed the title
|
According to discussion on irc, we adopted |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
member.dump,owner.dumpandeditor.dumpinEXPLDIR/list path/directory. On previous versions, only members were dumped and file name wassubscriber.closed.dump.Improvements:
sympa.pl:--dump--dump_usersdumps list members/owners/editors to file under list directory.--suck--restore_usersrestores list members/owners/editor from this file. This is the new option.--dump--dump_usersand--suck--restore_userswork only on open list and closed/pending lists are omitted. On previous versions of Sympa, only members were dumped and file name wassubscriber.db.dump.Fixed bug:
This PR may fix issue #232.
2018-04-21 Update: Renamed functions.