6.2.34 owner_domain fixes #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for the
owner_domainglobal validation code:The change in context for validating owner updates effectively disabled the
owner_domainglobal validation in 6.2.34. The update obtains the current list configuration separately via$self->{context}, rather than expecting$selfto be a complete list configuration hash. This allows the validation function to obtain the currentowner_domainandowner_domain_minconfig parameters for the list.When
owner_domainis in effect, updating owner's personal name and other fields failed unless the owner mail address also changed. The update is more careful to only look at owner address changes.Tweak the logging to hopefully be a little more informative when enabled