Use tidyall to ease tidying files #440
Conversation
- Code::TidyAll added as develop requirement in cpanfile - Add tidyall target to Makefile.am (to run it with the good options without pain) - Add dot/dot.tidyallrc - Add t/ and xt/ to perltidy test
|
Unfortunately, Test::Perltidy doesn't test .fcgi files, and doesn't allow to change the list of file extensions used to find files to test. |
|
Is there any reason why Test::PerlTidy can’t test *.fcgi.in ? |
|
Hardcoded values, that's all: https://metacpan.org/source/LARRYL/Test-PerlTidy-20130104/lib/Test/PerlTidy.pm#L130 |
|
What a self-righteousness! However, we could add self-made run_tests(), couldn’t we? I can try it. |
|
@ldidry, if you are ok for the PR above, please merge it and fix this PR. Then I'll merge this PR. |
|
I'll do that tomorrow. Thanks 👍 |
|
I tested your PR, it's working fine 👌 I'm not sure of the workflow that you want: do you want me to merge your PR in my branch or do you want me to merge your PR in sympa-6.2? |
|
I think of both pr to be merged into sympa-6.2 branch: When you merged my pr to sympa-6.2, I think you will have to fix your pr to resolve conflict before I will merge it to sympa-6.2. |
|
@ldidry, thanks for merging my PR. There are big conflicts due to the other commit. I'll solve them and complete merger. |
|
Done 🎉. |
Follow-up of #438
without pain)
+ Tidy up src/ t/ xt/ files