Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code tidying #486

Merged
merged 1 commit into from
Dec 1, 2018
Merged

Fix code tidying #486

merged 1 commit into from
Dec 1, 2018

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Nov 30, 2018

No description provided.

@ikedas
Copy link
Member

ikedas commented Nov 30, 2018

@ldidry, I run “make tidyall” just before 6.2.37b.2. Do you know why things went wrong? (Though I have no objection to merge this fix soon.)

@ldidry
Copy link
Contributor Author

ldidry commented Nov 30, 2018

I was about to say "Well, there's 29 commits between 6.2.37b.2 and current sympa-6.2 branch, I think that explains that.", but with a git blame on src/lib/Sympa/List.pm, it seems that a untidyed block of code has been there for 4 years.

I guess that's a glitch in perltidy.

I noticed today that perltidy can say a thing on a test, and find new unrelated things to tidy up after correction from the previous test. Some code may have been added that triggers perltidy like that.

@ikedas ikedas merged commit 366cb22 into sympa-community:sympa-6.2 Dec 1, 2018
@ikedas
Copy link
Member

ikedas commented Dec 1, 2018

Perltidy won't take the blame: I found it was due to quick fix for #461.
Anyway it should be merged.

@ldidry ldidry deleted the fix-tidying branch June 25, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants