Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill VOOT support #550

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Kill VOOT support #550

merged 1 commit into from
Feb 15, 2019

Conversation

xavierba
Copy link
Contributor

@xavierba xavierba commented Feb 7, 2019

This PR removes support for VOOT in Sympa.
It is not clear if there are any users of this feature. The code is bit-roting and VOOT itself seems dormant at best.
As mentioned on IRC, this is completely untested, not even build tested.

@dverdin
Copy link
Contributor

dverdin commented Feb 7, 2019

Actually, I don't know if it is still used. But if it is, it will be by the GÉANT community.
We should maybe ask them about it before removing it, even though it is unlikely they still use it.
I had a hard time making them use Sympa, I'd better not get into trouble with them.
Any problem about postponing this removal until we have their opinion?

@dverdin
Copy link
Contributor

dverdin commented Feb 7, 2019

On this topic, I wold add that having working code for Oauth is probably useful for the future of Sympa. I would rather have keep it than just drop it. the premise "I don't know if somebody uses it" seems thin to me. has the question been asked to the mailing lists?

@xavierba
Copy link
Contributor Author

xavierba commented Feb 7, 2019

@dverdin, no problem for postponing. Do you have a way to reach out to Géant community ?
I have not asked on the mailing list and this is indeed a better idea than a raw PR. Anyway, it's very unlikely the code is used, as it's not even distributed in the tarball.

@dverdin
Copy link
Contributor

dverdin commented Feb 7, 2019

Just to let you know: I had a contact with the head of PMO at GÉANT. He told me he would check about it.
Let me be clear: as for my own needs, I don't care about VOOT for now. But GÉANT is a very strong support for Sympa in Europe and I don't want to get in trouble with them. After all, they paid @markov to develop VOOT in the first place. They could certainly contribute further.

@ikedas
Copy link
Member

ikedas commented Feb 7, 2019

Note that it has not completed implementation.

At least I haven’t heard it is working as expected, and even it is not working as expected. I can’t believe that there can be any organizations using this feature.

@ikedas
Copy link
Member

ikedas commented Feb 8, 2019

I prepared additional removal of codes. @xavierba, you may cherry-pick it (or I can separately merge both changes by you and me).
xavierba/sympa@kill_voot...ikedas:xavierba/kill_voot

@racke
Copy link
Contributor

racke commented Feb 8, 2019

Just to let you know: I had a contact with the head of PMO at GÉANT. He told me he would check about it.
Let me be clear: as for my own needs, I don't care about VOOT for now. But GÉANT is a very strong support for Sympa in Europe and I don't want to get in trouble with them. After all, they paid @markov to develop VOOT in the first place. They could certainly contribute further.

I'm not aware that GÉANT is a very strong support for Sympa ... At any rate, the implementation was done 6 years ago and it isn't really functional until you utilize the ext directory.

Even if they still use it, the removal can be reversed but needs a integration of the complete VOOT code.

@ikedas ikedas added the design label Feb 12, 2019
@ikedas
Copy link
Member

ikedas commented Feb 14, 2019

FYI:

Development of VOOT looks quieting down after publication of SCIM as RFC 7642 - 7644. It is not so unusual that development of protocol is given up, even much it has been paid. And its value may not be masured only by its deliverables.

Anyways I'll merge this PR to remove works for VOOT from Sympa.

@racke
Copy link
Contributor

racke commented Feb 14, 2019

Thanks for the pointer, @ikedas. Please merge the PR 👍

@ikedas ikedas merged commit 5c58250 into sympa-community:sympa-6.2 Feb 15, 2019
@ikedas ikedas added this to the 6.2.42 milestone Feb 15, 2019
ikedas added a commit that referenced this pull request Feb 15, 2019
Additional removal of code to kill VOOT support (#550).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants