Sympa::Aliases::Template creates exclusive lock on local storage #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior is useless when aliases file is shared by multiple hosts with network drive. Fixed by creating lock at the same place as aliases file.
ikedas
changed the title
|
Makes sense to me 👍 |
|
I don't see any side effect that could come from this. |
ikedas
added a commit
to ikedas/sympa
that referenced
this pull request
Apr 25, 2019
… aliases file is opened. Fixed by opening aliases file as Sympa::LockedFile instance. Note: To keep exclusive processing by file lock effective, file won't be closed (unlocked) before newaliases will be finised.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is useless when aliases file is shared by multiple hosts with network drive.
Fixed by creating lock at the same place as aliases file.