Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button for full export of subscribers #616

Merged
merged 1 commit into from
May 28, 2019
Merged

Add a button for full export of subscribers #616

merged 1 commit into from
May 28, 2019

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented May 17, 2019 •
edited
Loading

  • Currently, only light export is available, thus export doesn’t contain
    the name of the subscribers. The button solves that.
  • The full export always includes a header:
    # Exported subscribers with search filter ""
    But it’s useless and maybe confusing when you use the full export from
    the button. I removed that header if no filter was sent
  • I changed an "unless defined" assignment to "//", I don't know if it’s
    ok to do that.

@ldidry ldidry requested review from racke, dverdin and ikedas May 17, 2019 10:18
@ikedas
Copy link
Member

ikedas commented May 19, 2019

  • I changed an "unless defined" assignment to "//", I don't know if it’s
    ok to do that.

Unfortunately Sympa has to support Perl 5.8.1 or later. // appeared on Perl 5.10.

@ikedas
Copy link
Member

ikedas commented May 19, 2019

See #620.

@ldidry
Copy link
Contributor Author

ldidry commented May 19, 2019

Thanks for the hint and the new issue, I feared something like that. I’ll revert my // change and redo it when Perl 5.8 support will be officially dropped.

@ldidry
Add a button for full export of subscribers
bfec592 
- Currently, only light export is available, thus export doesn’t contain
  the name of the subscribers. The button solves that.
- The full export always includes a header:
  # Exported subscribers with search filter ""
  But it’s useless and maybe confusing when you use the full export from
  the button. I removed that header if no filter was sent.
@ldidry
Copy link
Contributor Author

ldidry commented May 24, 2019

// removed.

ikedas
ikedas approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldidry, thanks for improvement. I think we should merge this pr and see what will happen.

@ikedas ikedas merged commit 686adb1 into sympa-community:sympa-6.2 May 28, 2019
@ikedas ikedas added this to the 6.2.44 milestone May 28, 2019
@ldidry ldidry deleted the add-full-export-button branch June 25, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikedas ikedas ikedas approved these changes

@racke racke Awaiting requested review from racke

@dverdin dverdin Awaiting requested review from dverdin

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.2.44
Development

Successfully merging this pull request may close these issues.
2 participants
@ldidry @ikedas