Trim fonts flavors to TTF/OTF only #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, do not trim .woff and .woff2 formats since they are lighter than ttf/otf (in fact, they are compressed ttf/otf). Those formats are the future, not the past like eot (that, as for me, you can remove). Woff is well supported by browsers: https://caniuse.com/#search=woff |
|
At present we will partially adopt this PR to keep woff/woff2 formats. Close. |
ikedas
added a commit
that referenced
this pull request
Aug 14, 2019
… ikedas Partial application of #714
|
@ikedas , sorry for not updating the PR myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, TTF and OTF font formats are supported in all browsers:
https://caniuse.com/#search=ttf
Subsequently, there's no need to clutter the distribution with font flavors that won't be used anyway.
Removing all but the TTF/OTF flavors for Font-Awesome and Foundation-Icons saves 350+KB.
Please note this change is unlikely to break any browser, as the third font shipped with Sympa, Raleway, is only distributed in the OTF flavor (and was only shipped in TTF flavor before #191).
The third commit is a fix to correct Raleway font format in default css. This supposedly minor bug, as it went unnoticed for more than a year, was introduced in #191.