Various improvements to --sync-include output #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racke
force-pushed
the
topic/cli-sync-include
branch
from
3875891
to
9234002
Compare
racke
force-pushed
the
topic/cli-sync-include
branch
from
9234002
to
a050cfd
Compare
ikedas
reviewed
Nov 8, 2019
racke
force-pushed
the
topic/cli-sync-include
branch
from
7a17efa
to
e3ee366
Compare
|
I would also like to see the two things in the output:
But I realized that especially the latter requires a night dive 😜 into the Sympa sources. So for now the PR is complete from my point of view. |
ikedas
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with: Fix typo in output from --sync_include commandline option.
More to come.