Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Sympa daemon crash due to a broken plugin module. #807

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

racke
Copy link
Contributor

@racke racke commented Nov 21, 2019

A mistake in a plugin module crashed sympa hard:

Nov 21 17:54:14 local-sympa sympa_msg[14599]: err main::#243 > Sympa::Spindle::spin#95 > Sympa::Spindle::TransformOutgoing::_twist#48 > Sympa::Message::Plugin::execute#61 > (eval)#1 > (eval)#1 > Sympa::Message::Plugin::BEGIN#1 DIED: Global symbol "$list" requires explicit package name (did you forget to declare "my $list"?) at /usr/local/lib/site_perl/Sympa/Plugin/DistributionNotification.pm line 24. Compilation failed in require at (eval 208) line 1.
Nov 21 17:54:14 local-sympa systemd[1]: sympa.service: Main process exited, code=exited, status=255/n/a
Nov 21 17:54:14 local-sympa systemd[1]: sympa.service: Unit entered failed state.
Nov 21 17:54:14 local-sympa systemd[1]: sympa.service: Failed with result 'exit-code'.

Justification for the introduction of the Module::Runtime dependency:

  • does the right thing without head scratching and homegrown code
  • small footprint

@racke racke requested a review from ikedas November 21, 2019 17:18
Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikedas ikedas added this to the 6.2.50 milestone Nov 22, 2019
@ikedas ikedas merged commit 8f50854 into sympa-community:sympa-6.2 Nov 22, 2019
@racke racke deleted the pr/sympa-plugin-crash branch November 23, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants