Refactoring requests more #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egrated to Sympa::Request framework.
…_list) to be integrated to Sympa::Request framework.
…were not updated.
…ries. This also fixes following bug: [bug] digest spool was not renamed when list was renamed.
… to the list with system address, <sympa@domain> or <listmaster@domain>.
…tion->next may crash.
|
With a better database schema, list renames would be automatically reflected in the db by foreign keys/trigger. |
It's interesting point. When we move to ORM instead of current home-made database management, it would be considered. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of refactorings done by PR #26, #30, #33, #65. In this PR, following handlers are introduced:
declto decline held requests. On WWSympa, decl_add and decl_del (formerly ignoresub and ignoresig).move_listto move or copy list, formerly rename_list and copy_list on WWSympa.And, "
sympa.pl --rename_list" and "sympa.pl --import" also uses request handlers.Fixed bugs:
[bug] Content of several tables and spools were not updated when list was renamed: exclusion_table, notification_table, digest spool, topic spool, outgoing (bulk) spool.
[bug] Couldn't rename/copy to list with the same name and other domaain.
[bug] If
list_check_smtpis disabled, a list can be renamed or copied to the list with system address, <sympa@domain> or <listmaster@domain>.[bug] If digest spool contains garbage, Sympa::Spool::Digest::Collection->next may crash.
Known bug: