Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging of open file error in Config_XML's constructor. #906

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix logging of open file error in Config_XML's constructor. #906

merged 2 commits into from
Mar 12, 2020

Conversation

racke
Copy link
Contributor

@racke racke commented Mar 6, 2020

No description provided.

ikedas
ikedas reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either of below is better:

  • $! may be $ERRNO thanks to English.
  • %m in format string for syslog() may be used.

@racke
Copy link
Contributor Author

racke commented Mar 7, 2020

I prefer the first approach, as it improves clarity for casual code lurkers :-). Code adjusted. Thanks for the help @ikedas

@ikedas ikedas added the bug label Mar 12, 2020
@ikedas ikedas merged commit 80be409 into sympa-community:sympa-6.2 Mar 12, 2020
@ikedas ikedas added this to the 6.2.56 milestone Mar 12, 2020
@racke racke deleted the pr/config-xml-fix-logging branch March 12, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikedas ikedas ikedas approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2.56
Development

Successfully merging this pull request may close these issues.
2 participants
@racke @ikedas