2 fixes related to list families #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2020 16:03
…s only one. Also did return status 0 wen we encoutered errors
…uired; check_param_constraint() only make sense when a family list gets re/instantiated. These calls are very expensive for institutions heavily using families. Our production list service has 2.500 lists; most of them belonging to a family. In these circumstances wwsympa.fcgi startup takes 3 minutes. Applying this patch lowers wwsympa.fcgi to 35 seconds. Much better. I did some tests to ensure this patch does not prevent param_constraint checking while instantiating, modifying, adding lists to families. My tests (based on Test::BDD::Cucumber) are public on https://github.com/salaun-urennes1/sympa-functional-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One minor fix to handle errors when running
sympa.pl --instantiate_familyThe other is more important for us because it makes our Sympa GUI almost unusable because of horrible performances on global functions (/lists mainly).