Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue DVU when modifying or creating attribute func bindings for variants with existing components #4107

Conversation

britmyerss
Copy link
Contributor

@britmyerss britmyerss commented Jul 7, 2024

One other change here to discuss Monday:

  • When resetting an attribute prototype, if the prototype is for a Prop, default to the unset intrinisic func
  • If it's for an output socket, reset to the identity func, so that regenerate can re-set the prototype to a value from if it's defined in the asset definition func

Update: discussed and we are not going to do this as it prevents that prop from ever having a default value again (under current constraints)

@github-actions github-actions bot added the A-dal label Jul 7, 2024
@britmyerss britmyerss force-pushed the brit/bug-432-enqueue-dvu-when-making-changes-to-bindings-for-schema branch 2 times, most recently from 30f52ba to 0b62030 Compare July 8, 2024 23:36
@britmyerss britmyerss added this pull request to the merge queue Jul 8, 2024
@britmyerss britmyerss removed this pull request from the merge queue due to a manual request Jul 8, 2024
@britmyerss britmyerss force-pushed the brit/bug-432-enqueue-dvu-when-making-changes-to-bindings-for-schema branch from 0b62030 to 75a1b6e Compare July 8, 2024 23:53
@britmyerss britmyerss added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit e5f7008 Jul 9, 2024
8 checks passed
@britmyerss britmyerss deleted the brit/bug-432-enqueue-dvu-when-making-changes-to-bindings-for-schema branch July 9, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant