feat(snipeit): use existing secret for env var config #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update references from `mysql` to `config.mysql` in `deployment.yaml` - Update references from `mysql` to `config.mysql` in `secret.yaml` Signed-off-by: Quentin BERTRAND <[email protected]>
- Update environment variable handling for MySQL credentials - Refactor the conditional checks for MySQL secrets - Reorganize setting of environment variables for MySQL connection details - Adjust handling of `APP_KEY` secret retrieval Signed-off-by: Quentin BERTRAND <[email protected]>
- Update environment variable handling for MySQL user, database, password, port, and key - Improve handling of secret key references for MySQL configuration - Adjust the way secrets are referenced for MySQL configuration Signed-off-by: Quentin BERTRAND <[email protected]>
- Update the `values.yaml` file in the `snipeit` directory Signed-off-by: Quentin BERTRAND <[email protected]>
- Update variable references from `config.mysql` to `mysql` in `snipeit/templates/secret.yaml` - Correct variable names in the file to match the correct structure Signed-off-by: Quentin BERTRAND <[email protected]>
- Comment out `keySecretName` and `keySecretKey` settings - Add comments for `keySecretName` and `keySecretKey` settings Signed-off-by: Quentin BERTRAND <[email protected]>
- Update the image tag to "v6.4.2" in values.yaml Signed-off-by: Quentin BERTRAND <[email protected]>
- Update the `path` field in the `ingress` section. Signed-off-by: Quentin BERTRAND <[email protected]>
- Update the `path` value in the ingress configuration to `/` Signed-off-by: Quentin BERTRAND <[email protected]>
- Update the image tag to an empty value in `values.yaml` in the `snipeit` directory. Signed-off-by: Quentin BERTRAND <[email protected]>
THE SUMMARY: - Refactor the function to use a more efficient algorithm - Update error handling for better user experience Signed-off-by: Quentin BERTRAND <[email protected]>
|
@jnmcfly 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
I need to use secrets created by external-secrets.
How ?
Use env value from secrets ref