-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export EscapeError from the crate #584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry
eadbc41
to
aa33bb0
Compare
@Mingun: I've updated the changelog |
Changelog.md
Outdated
|
||
### Misc Changes | ||
|
||
- [#579]: `ElementWriter.write_inner_content` now uses a `FnOnce` instead of a more restrictive `Fn` closure | ||
- [#584]: Export EscapeError from the crate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should put changelog under Unreleased section instead of modifying existing release. Also add a backticks around the type:
- [#584]: Export EscapeError from the crate | |
- [#584]: Export `EscapeError` from the crate |
This is useful when manually calling `unscape`
aa33bb0
to
67e8f1a
Compare
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [quick-xml](https://github.com/tafia/quick-xml) | dependencies | patch | `0.28.1` -> `0.28.2` | --- ### Release Notes <details> <summary>tafia/quick-xml</summary> ### [`v0.28.2`](https://github.com/tafia/quick-xml/blob/HEAD/Changelog.md#​0282----2023-04-12) [Compare Source](tafia/quick-xml@v0.28.1...v0.28.2) ##### New Features - [#​581]: Allow `Deserializer` to set `quick_xml::de::EntityResolver` for resolving unknown entities that would otherwise cause the parser to return an \[`EscapeError::UnrecognizedSymbol`] error. ##### Misc Changes - [#​584]: Export `EscapeError` from the crate - [#​581]: Relax requirements for `unsescape_*` set of functions -- their now use `FnMut` instead of `Fn` for `resolve_entity` parameters, like `Iterator::map` from `std`. [#​581]: tafia/quick-xml#581 [#​584]: tafia/quick-xml#584 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDEuMCJ9--> Co-authored-by: cabr2-bot <[email protected]> Co-authored-by: crapStone <[email protected]> Co-authored-by: crapStone <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1862 Reviewed-by: crapStone <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This is useful when manually calling
unscape