Improve serialization of xs:lists with empty elements
#665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- QNameDeserializer does not tested with tuple structs - SimpleTypeDeserializer does not tested with tuple structs - (stilistic) Some enum tests named "tuple_struct" [variant] instead of "tuple" [variant]
…ceptable characters
failures (3):
se::simple_type::tests::simple_seq::all_items_empty
se::simple_type::tests::simple_seq::some_items_empty1
se::simple_type::tests::simple_seq::some_items_empty2
…when it is required
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 64.43% 64.70% +0.27%
==========================================
Files 37 37
Lines 17487 17624 +137
==========================================
+ Hits 11267 11404 +137
Misses 6220 6220
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR serialization I implement skipping unnecessary indentation or writing list delimiters, if list element was serialized to an empty string.
Also fixed minor bugs in tests for
SimpleTypeDeserializerandQNameDeserializer-- I realized, that some tuple struct tests actually duplicate tuple tests.