-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed expand empty not expanding tags with attributes #704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for that? There are no writer-only tests so I suggest to create tests/writer-config.rs
and add test for expand option there (it then will be filled with tests for other options as well, similarly to reader-config.rs
).
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 65.06% 65.31% +0.25%
==========================================
Files 38 38
Lines 17954 18131 +177
==========================================
+ Hits 11682 11843 +161
- Misses 6272 6288 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @M-Valts. I still wait tests to ensure that now it works in all situations. |
Thanks, @M-Valts ! |
In PR #620 the expand_empty_elements function was added to the serializer. With the current implementation only unit variants are expanded, but if a tag has an attribute it would not expand the tag which seems inconsistent.