-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add flattened enum deserialization #738
Conversation
Thanks for the example. Need to fix lint issues and find a way to enable "serialize" feature for this example or just run it when that feature is active. |
641a4db
to
e74f294
Compare
It should be fixed, sorry for the oversight. Cheers |
e74f294
to
a3c5a93
Compare
a3c5a93
to
c554ed1
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #738 +/- ##
==========================================
- Coverage 61.48% 61.24% -0.24%
==========================================
Files 38 39 +1
Lines 16213 16277 +64
==========================================
+ Hits 9968 9969 +1
- Misses 6245 6308 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Forget to mention: could you add an entry to the Changelog.md about new example, so people will aware that it is exist? Remember, that changelog contains section with changes and list of link targets at the end of each chapter (== version). This is standard markdown way to split link usage and link target. All everything is good. |
c554ed1
to
602323a
Compare
done. thanks |
Add a small example about flattened enum deserialization. This is a small workaround around serde's [serde's issue](serde-rs/serde#1905). Big thanks to @Mingun for (most) of the code + help! Signed-off-by: Frank Villaro-Dixon <[email protected]>
602323a
to
5d76174
Compare
Thanks! I slightly improved text in changelog |
Add a small example about flattened enum deserialization. This is a small workaround around serde's serde's
issue.
Big thanks to @Mingun for (most) of the code + help!