-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deserializer.into_inner destructor #743
Conversation
Yes, nice addition. Could you also add a changelog entry? Some tests would be also good -- maybe add a doc example? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
- Coverage 61.24% 61.12% -0.13%
==========================================
Files 39 39
Lines 16277 16257 -20
==========================================
- Hits 9969 9937 -32
- Misses 6308 6320 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Maybe let's add also |
I've added doc example and an example file |
|
I hope addition of |
ab9e66a
to
7a12fdf
Compare
I modified your PR slightly, I hope I didn't lost something important:
The two things remains about which I'm not sure yet:
So, what do you think? |
|
Ok, then I tend to keep only |
7a12fdf
to
e031a6b
Compare
❤️ |
It's useful to extract position from Deserializer when error occurs.
Line and column can be extracted from inner reader without the need for RefCell inside a custom Cursor.
Other serde crate
rmp_serde
supports.into_inner()
https://docs.rs/rmp-serde/latest/rmp_serde/decode/struct.Deserializer.html#method.into_inner
or even better: