Update GraphQL.js dependency #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now our graphql-tools tests are failing on Node 4 because NPM 2 enforces peer dependencies and we depend on this package for our tests.
|
@taion I see you closed a similar PR just now, but I'd suggest merging this will unblock a non-trivial number of people using Node 4 from using GraphQL.js 0.8. |
|
I didn't close it! I wanted to fix the tests to assert the new null behavior. I'll take a look when I get back to my computer. |
|
Oh, the PR was closed by the contributor. No worries, it's not a huge rush! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our graphql-tools tests are failing on Node 4 because NPM 2
enforces peer dependencies and we depend on this package for our tests.