Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add GraphQLJSONObject #57

Merged
merged 2 commits into from
Mar 29, 2019
Merged

feat: Add GraphQLJSONObject #57

merged 2 commits into from
Mar 29, 2019

Conversation

taion
Copy link
Owner

@taion taion commented Mar 28, 2019

No description provided.

@taion
Copy link
Owner Author

taion commented Mar 28, 2019

cc @sloria @itajaja @yodaiken

taion
taion commented Mar 29, 2019
View reviewed changes
src/index.js
@@ -5,6 +5,26 @@ function identity(value) {
return value;
}

function ensureObject(value) {
if (typeof value !== 'object' || value === null || Array.isArray(value)) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jquense is there a better way to do this?

@taion taion merged commit 1e19d66 into master Mar 29, 2019
@taion taion deleted the GraphQLJSONObject branch March 29, 2019 18:58
taion added a commit that referenced this pull request Mar 29, 2019
@taion
Revert "feat: Add GraphQLJSONObject (#57)"
45dfd1e 
This reverts commit 1e19d66.
@taion taion mentioned this pull request Mar 29, 2019
Merged
taion added a commit that referenced this pull request Mar 29, 2019
@taion
fix: Revert unintentional breaking change for CommonJS exports (#59)
e0204ad 
Revert "feat: Add GraphQLJSONObject (#57)"

This reverts commit 1e19d66.

Fixes #58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taion