Add jsblocks #1297

astoilkov · 2015-05-14T12:32:02Z

jsblocks have been developed for the past couple of years. Two weeks ago it was released and collected more than 800 stars. You could take a look at some of the advantages of the project here. Some of the things include:

Performance
Debugging exprience
Server-side rendering

Test results:

TodoMVC - blocks
  When page is initially opened
    √ should focus on the todo input field
  No Todos
    √ should hide #main and #footer (109ms)
  New Todo
    √ should allow me to add todo items (459ms)
    √ should clear text input field when an item is added (288ms)
    √ should append new items to the bottom of the list (570ms)
    √ should trim text input (262ms)
    √ should show #main and #footer when items added (253ms)
  Mark all as completed
    √ should allow me to mark all items as completed (610ms)
    √ should allow me to clear the completion state of all items (687ms)
    √ complete all checkbox should update state when items are completed / cleared (739ms)
  Item
    √ should allow me to mark items as complete (575ms)
    √ should allow me to un-mark items as complete (585ms)
    √ should allow me to edit an item (942ms)
    √ should show the remove button on hover
  Editing
    √ should hide other controls when editing (672ms)
    √ should save edits on enter (867ms)
    √ should save edits on blur (942ms)
    √ should trim entered text (868ms)
    √ should remove the item if an empty text string was entered (800ms)
    √ should cancel edits on escape (939ms)
  Counter
    √ should display the current number of todo items (399ms)
  Clear completed button
    √ should display the correct text (571ms)
    √ should remove completed items when clicked (865ms)
    √ should be hidden when there are no items that are completed (615ms)
  Persistence
    √ should persist its data (854ms)
  Routing
    √ should allow me to display active items (633ms)
    √ should respect the back button (892ms)
    √ should allow me to display completed items (616ms)
    √ should allow me to display all items (776ms)
    √ should highlight the currently applied filter (678ms)


30 passing (3m)

urrgur · 2015-05-25T19:45:56Z

👎

mauricio-frontend · 2015-05-26T18:55:25Z

This is a good Idea to put this on TodoMVC, I test JSBlock and like of your performance.

arthurvr · 2015-05-31T15:49:39Z

examples/blocks/.editorconfig

+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false


Please remove this file. We have our own code styling rules and those are in the root directory :) Same thing for .gitattributes :)

arthurvr · 2015-05-31T15:55:32Z

Please add this example to learn.json and to the home page.
should the folder be named blocks or jsblocks?
Please commit all dependencies as seen in other examples.

Can you also fix the JSHint errors?

astoilkov · 2015-05-31T16:05:58Z

No problem. I will fix everything. Can you just clarify what do you mean by adding the example to the home page? Which home page and where?

arthurvr · 2015-05-31T16:19:49Z

@astoilkov To the home page of the website, index.html. If you have any other questions don't hesitate to ask. Thanks for working on this!

astoilkov · 2015-06-02T08:07:10Z

I think I fixed all reported things. As for the name of the folder - I have removed js because the npm package is called blocks and it is obvious that is a JavaScript framework. However, if you suggest that it is better to add the js I will rename the folder to jsblocks.

arthurvr · 2015-06-06T09:03:59Z

I think I fixed all reported things. As for the name of the folder - I have removed js because the npm package is called blocks and it is obvious that is a JavaScript framework. However, if you suggest that it is better to add the js I will rename the folder to jsblocks.

Well, we're not talking about an extension here. What's the name of the framework? Blocks? Or jsblocks?

arthurvr · 2015-06-06T09:05:47Z

examples/blocks/.gitignore

+
+node_modules/todomvc-common/*
+!node_modules/todomvc-common/base.css
+!node_modules/todomvc-common/base.js


This gitignore looks okay but you forgot to actually add the files too.

astoilkov · 2015-06-06T09:11:18Z

It's jsblocks. However, in jsdelivr and DefinitelyTyped the folders are called blocks. So its your call. I can't decide.

arthurvr · 2015-06-06T09:15:53Z

examples/blocks/index.html

@@ -0,0 +1,59 @@
+<!doctype html>
+<html lang="en" data-framework="jsblocks">


this should be equal to the folder name

arthurvr · 2015-06-06T09:18:28Z

Looks like I'm able to add empty todos.

arthurvr · 2015-06-06T09:19:23Z

@astoilkov jsblocks, then.

arthurvr · 2015-06-06T09:35:32Z

examples/blocks/js/app.js

+		},
+
+		clearCompleted: function () {
+			this.removeAll(function (todo) {


Might be just my feeling but removeAll is a confusing name if you only want to remove specific items.

astoilkov · 2015-06-06T15:03:48Z

Ok. Fixed noted things. Thanks for being so patient. :)

samccone · 2015-06-06T23:50:15Z

@astoilkov mind squashing down into a single commit please?

samccone · 2015-06-06T23:50:58Z

examples/jsblocks/index.html

+		<link rel="stylesheet" href="node_modules/todomvc-app-css/index.css">
+	</head>
+	<body>
+		<section id="todoapp" data-query="view(Todos)" class="todoapp">


Should we use the v2 app spec here (classes instead of IDs) ?

I added the id because the tests were failing without it. I can remove them quickly if this is not a problem.

You can remove the id's. We're going to update the test suite shortly.

astoilkov · 2015-06-07T07:19:20Z

@samccone When everything is perfect I will make it a single commit. Just one question. I will do it by creating a new pull request with the one commit is there any other way for making it only one commit?

arthurvr · 2015-06-07T07:29:07Z

When everything is perfect I will make it a single commit. Just one question. I will do it by creating a new pull request with the one commit is there any other way for making it only one commit?

Just squash them using a rebase and then force push this branch. If you've got troubles with that I'm happy to squash stuff for you while merging :)

arthurvr · 2015-06-07T07:32:06Z

index.html

@@ -278,6 +278,9 @@
 								<li class="routing">
 									<a href="examples/webrx/" data-source="http://webrxjs.org" data-content="WebRx is a Javascript MVVM-Framework that combines functional-reactive programming with declarative Data-Binding, Templating and Client-Side Routing. The framework is built on top of ReactiveX for Javascript (RxJs) which is a powerful set of libraries for processing and querying asynchronous data-streams that can originate from diverse sources such as Http-Requests, Input-Events, Timers and much more.">WebRx</a>
 								</li>
+								<li class="routing">
+									<a href="examples/blocks/" data-source="http://jsblocks.com" data-content="From simple user interfaces to complex single-page applications using faster, server-side rendered and easy to learn framework">jsblocks</a>


This link is now broken ;)

arthurvr · 2015-06-07T07:33:39Z

Looks like I'm able to add empty todos.

This is only partially fixed. I'm still able to edit an existing one with only whitespace.

arthurvr · 2015-06-07T07:34:52Z

Could you please add some comments to the code? Specifically to the parts which might confuse beginners. (#385)

arthurvr · 2015-07-11T11:05:47Z

ping @astoilkov, was you able to publish a release?

astoilkov · 2015-07-11T11:07:21Z

@arthurvr No. Sorry. I was on a holiday and returned yesterday. I am a little sick now but I will publish a release next week.

arthurvr · 2015-07-11T11:10:43Z

Thanks.

astoilkov · 2015-07-21T07:20:07Z

Sorry for the delay. Here are the updates. :)

samccone · 2015-07-21T13:45:19Z

@astoilkov looks like we need a rebase 😉

astoilkov · 2015-07-21T14:00:13Z

I am not expert on git. Is there any possibility someone else can do it? If no...can you explain me the required steps you want me to take.

sindresorhus · 2015-08-21T17:58:25Z

https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

astoilkov · 2015-08-21T18:03:41Z

Thanks @sindresorhus . It's time I do this.

arthurvr · 2015-08-26T10:27:21Z

ping :)

astoilkov · 2015-08-26T14:21:12Z

Yep. I am in process of completing it. Hope will do this in the next days.

samccone · 2015-08-26T14:21:35Z

awesome thanks @astoilkov

samccone · 2015-09-29T03:06:44Z

Hey @astoilkov looks like you are still failing a few tests, have you had a moment to take a look?

astoilkov · 2015-09-30T13:42:19Z

Yes. I found the problem. I will try fixing it without pushing to the todomvc repository. I will write back once done.

samccone · 2015-09-30T15:46:24Z

great thanks a bunch @astoilkov

astoilkov · 2015-10-05T06:26:07Z

Hi @samccone. The issue is fixed. However, I will need to bump up the jsblocks version. I will fix a few more issues, bump up the version and then update it here.

samccone · 2015-10-05T16:20:36Z

ok thanks for keeping us in the loop @astoilkov !!!

samccone · 2015-10-12T16:18:48Z

Hey @astoilkov any word :)

astoilkov · 2015-10-12T16:21:19Z

Yes. As I said I will release this week. Today we did the last bug fix that we wanted to include in the release. I will spend some time these days to make the release.

samccone · 2015-10-12T16:21:53Z

awesome ✨

Just doing my weekly review of open PRs :) :)

astoilkov · 2015-10-13T10:53:28Z

Ok. I am ready with the release. Now the only thing I should do is update the pull request adding the latest jsblocks version. I have a few questions though:

I would probably need to rebase again right? This is extremely hard for me so I ask an external person for this to help me so it could take some time.
I think after the last rebase we have wiped out some of the changes in the index.html and the jsblocks framework isn't there. Can you confirm that? If this is true I should add it again right?

samccone · 2015-10-13T23:14:56Z

would probably need to rebase again right? This is extremely hard for me so I ask an external person for this to help me so it could take some time.

Yep, you will want to rebase, however there are no conflicts so it should be as simple as git fetch <remote name>

git rebase <remote name> master

then git push -f

If this is true I should add it again right?

Yep add it back in :)

samccone · 2015-10-16T21:48:38Z

Hey guys, I am going to close the PR, just ping us when you push and think it is good to go. Thanks

astoilkov · 2015-10-16T21:50:29Z

👍

Kanaye · 2015-10-16T23:01:22Z

Hey guys. We just updated the Repo and think we are ready to go 😄.

[edit]:
Sorry seems I derped with squashing the repo while in a closed PR. Didn't know that behaviour of github.
Can you do something about that or do we have to open a new one.
/cc @samccone @arthurvr

samccone · 2015-10-17T00:06:32Z

oh looks like it freaked out :( @Kanaye mind just opening a new one and linking it? Thanks!

arthurvr added the new app label May 14, 2015

arthurvr reviewed May 31, 2015
View reviewed changes

arthurvr reviewed Jun 6, 2015
View reviewed changes

samccone reviewed Jun 6, 2015
View reviewed changes

arthurvr reviewed Jun 7, 2015
View reviewed changes

jsblocks TodoMVC implementation

b33d10d

Merge remote-tracking branch 'tastejs/master'

3d00729

astoilkov mentioned this pull request Oct 4, 2015

Added garbadge collection for observables._expressions. FIxes #90 astoilkov/jsblocks#94

Merged

samccone closed this Oct 16, 2015

Kanaye mentioned this pull request Oct 17, 2015

Add jsblocks #1477

Merged

		@@ -0,0 +1,59 @@
		<!doctype html>
		<html lang="en" data-framework="jsblocks">

Add jsblocks #1297

Add jsblocks #1297

Conversation

astoilkov commented May 14, 2015

urrgur commented May 25, 2015

mauricio-frontend commented May 26, 2015

Choose a reason for hiding this comment

arthurvr commented May 31, 2015

astoilkov commented May 31, 2015

arthurvr commented May 31, 2015

astoilkov commented Jun 2, 2015

arthurvr commented Jun 6, 2015

Choose a reason for hiding this comment

astoilkov commented Jun 6, 2015

Choose a reason for hiding this comment

arthurvr commented Jun 6, 2015

arthurvr commented Jun 6, 2015

Choose a reason for hiding this comment

astoilkov commented Jun 6, 2015

samccone commented Jun 6, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astoilkov commented Jun 7, 2015

arthurvr commented Jun 7, 2015

Choose a reason for hiding this comment

arthurvr commented Jun 7, 2015

arthurvr commented Jun 7, 2015

arthurvr commented Jul 11, 2015

astoilkov commented Jul 11, 2015

arthurvr commented Jul 11, 2015

astoilkov commented Jul 21, 2015

samccone commented Jul 21, 2015

astoilkov commented Jul 21, 2015

sindresorhus commented Aug 21, 2015

astoilkov commented Aug 21, 2015

arthurvr commented Aug 26, 2015

astoilkov commented Aug 26, 2015

samccone commented Aug 26, 2015

samccone commented Sep 29, 2015

astoilkov commented Sep 30, 2015

samccone commented Sep 30, 2015

astoilkov commented Oct 5, 2015

samccone commented Oct 5, 2015

samccone commented Oct 12, 2015

astoilkov commented Oct 12, 2015

samccone commented Oct 12, 2015

astoilkov commented Oct 13, 2015

samccone commented Oct 13, 2015

samccone commented Oct 16, 2015

astoilkov commented Oct 16, 2015

Kanaye commented Oct 16, 2015

samccone commented Oct 17, 2015